Author Topic: mod_autohost and 1.3.4rc1  (Read 1830 times)

Offline cmerriman

  • Regular User
  • **
  • Posts: 37
    • View Profile
mod_autohost and 1.3.4rc1
« on: January 28, 2011, 07:17:19 pm »
Fails compile with:  mod_autohost.c:416: error: too many arguments to function pr_inet_create_conn.

It appears this:
2010-03-08 18:38  castaglia

   * contrib/mod_ctrls_admin.c, contrib/mod_qos.c, include/bindings.h,
     include/compat.h, include/dirtree.h, include/inet.h,
     modules/mod_core.c, modules/mod_ident.c, src/bindings.c,
     src/data.c, src/dirtree.c, src/inet.c, src/main.c:
      Removed the unused server_list argument from
      pr_inet_create_conn() and friends.  This also obseleted the
      backward-compatibilty macros for these functions.

should have been applied to mod_autohost as well.


This fixed the problem for me:

--- ftptoday-ftpd-17/contrib/mod_autohost.c.orig        2011-01-28 11:11:52.000000000 -0500
+++ ftptoday-ftpd-17/contrib/mod_autohost.c     2011-01-28 11:12:40.000000000 -0500
@@ -408,12 +408,7 @@
           continue;
         }

-        /* Create a listening socket for this port.  The given server list
-         * turns out not to be needed or even used by pr_inet_create_conn().
-         * Figures.
-         */
-        listener = pr_inet_create_conn(autohost_pool, autohost_server_list,
-          -1, main_server->addr, ports, FALSE);
+        listener = pr_inet_create_conn(autohost_pool, -1, main_server->addr, ports, FALSE);
         if (listener == NULL) {
           (void) pr_log_writefile(autohost_logfd, MOD_AUTOHOST_VERSION,
             "error opening new listening socket for port %d: %s", ports,


Offline castaglia

  • Administrator
  • Support Hero
  • *****
  • Posts: 5335
    • View Profile
    • http://www.castaglia.org/
Re: mod_autohost and 1.3.4rc1
« Reply #1 on: December 10, 2015, 06:46:42 pm »
Thanks!  Just wanted to point out that this patch was applied a while ago; see:

  https://github.com/Castaglia/proftpd-mod_autohost

 

sighted planning